Skip to content
This repository was archived by the owner on Jun 28, 2022. It is now read-only.

Bug in posts.js - Not filtering out deleted posts #7

Open
samburden opened this issue Aug 28, 2017 · 2 comments
Open

Bug in posts.js - Not filtering out deleted posts #7

samburden opened this issue Aug 28, 2017 · 2 comments

Comments

@samburden
Copy link

The getAll function in posts.js has a bug that causes deleted posts to not be filtered out. On line 60 there is the following let filtered_keys = keys.filter(key => !posts.deleted) but that should be let filtered_keys = keys.filter(key => !posts[key].deleted)

@nathanhannig
Copy link

Thank you, I have implemented the fix to my code and is working well. Hopefully they will fix this ASAP for the rest of the people.

@rsgrafx
Copy link

rsgrafx commented Sep 13, 2017

I realized this also. I had to implement a filter to fix the issue.

rsgrafx referenced this issue in rsgrafx/udacity-readable Sep 25, 2017
…er/issues/7` Pointed out but tthat was causing issue with posts not being deleted

Implemented this fix pointed out by fellow programmer
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants