Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

callVariant fails on a short circRNA with 25 SNVs #885

Closed
zhuchcn opened this issue Jan 18, 2025 · 0 comments · Fixed by #886
Closed

callVariant fails on a short circRNA with 25 SNVs #885

zhuchcn opened this issue Jan 18, 2025 · 0 comments · Fixed by #886
Assignees

Comments

@zhuchcn
Copy link
Member

zhuchcn commented Jan 18, 2025

Problem

For backbones with very dense variants, we have a mechanism to gradually reduce the max number of variants in each node to reduce the complexity. In a latest run, a sample from CPTAC-LUAD, a sample failed when the max variants were reduced to 1. It is a circRNA with 2 exons (so a small one) with ~25 mutations (very dense).

Potential Solution

When a max number of variants is set, it only limits the final variant peptide calling step, but not the intermediate step which turns the variant peptide graph into cleavage graph. So we can also apply this limit to that step so the complexity could be reduced much earlier, which is the step that takes a lot of time right now.

@zhuchcn zhuchcn self-assigned this Jan 18, 2025
zhuchcn added a commit that referenced this issue Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant