Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probabilistic phylogeny tree #63

Open
whelena opened this issue Nov 23, 2022 · 1 comment
Open

Probabilistic phylogeny tree #63

whelena opened this issue Nov 23, 2022 · 1 comment
Labels
enhancement New feature or request future Planned future features

Comments

@whelena
Copy link
Collaborator

whelena commented Nov 23, 2022

Add probability column to input dataframe

Probability column can also be a p-value.
Probabilistic edge (connected to a node with multiple parents) should be different in colour or line type compared to 'exact' edges (connecting node with only one parent).

Example:
Screen Shot 2022-11-22 at 4 54 37 PM

** labels (0.6, 0.4) do not have to be included

@whelena whelena added the enhancement New feature or request label Nov 23, 2022
@dan-knight
Copy link
Collaborator

Graphs like this would be useful! As it stands, the algorithm relies on the constraints set by tree structures (single-parent per child) in order to arrange the nodes properly. This wouldn't be too disruptive to the existing algorithm if we could consider a single parent the "true" primary parent for the purposes of positioning nodes. Then, we would just draw other secondary arrows (which could be styled using color, linestyle, opacity, etc.) without affecting node positions. This would surely result in some ugly trees, but users would have many options for resolving those issues depending on their particular tree (angle overrides, lengths, opacity, etc.).

@dan-knight dan-knight added the future Planned future features label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request future Planned future features
Projects
None yet
Development

No branches or pull requests

2 participants