Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for node size in branch lengths #21

Open
dan-knight opened this issue Jun 22, 2022 · 0 comments
Open

Account for node size in branch lengths #21

dan-knight opened this issue Jun 22, 2022 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@dan-knight
Copy link
Collaborator

if (!nodes && length.from.node.edge) {
    tree <- adjust.branch.lengths(v,tree,node.radius, scale1);
    }

This does not always calculate accurate lengths for the second length column (when provided). I suspect it has to do with converting back from scaled (by scale1) units.

I removed this functionality temporarily until this is resolved. I also removed the nodes and length.from.node.edge parameters from SRCGrob, as they can be added back in without losing backwards compatibility.

@dan-knight dan-knight added bug Something isn't working enhancement New feature or request labels Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant