Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fish plot polygon bug with 3 children #159

Open
whelena opened this issue Nov 5, 2024 · 1 comment · May be fixed by #170
Open

Fish plot polygon bug with 3 children #159

whelena opened this issue Nov 5, 2024 · 1 comment · May be fixed by #170
Labels
enhancement New feature or request future Planned future features

Comments

@whelena
Copy link
Collaborator

whelena commented Nov 5, 2024 

phy.dt <- data.table(
    parent = c(NA, 1, 1, 2, 1),
    label = c(1:5),
    CP = c(1.2, 0.5, 0.4, 0.2, 0.3)
    );
SRCGrob(phy.dt)

Here, node 1 has 3 children: 2,3,5. Running SRCgrob() results in this error: Error in if (v$id == siblings$id[which.min(siblings$x.mid)]) { : the condition has length > 1`
@whelena whelena added bug Something isn't working future Planned future features labels Nov 5, 2024
@whelena
Copy link
Collaborator Author

whelena commented Nov 11, 2024

I see that this is an intended behaviour. Marking as future enhancement instead

@whelena whelena added enhancement New feature or request and removed bug Something isn't working labels Nov 11, 2024
@dan-knight dan-knight linked a pull request Jan 8, 2025 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request future Planned future features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix polygon siblings issue uclahs-cds/package-CancerEvolutionVisualization
1 participant
@whelena