Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column names for length results in inconsistent behaviour #162

Open
whelena opened this issue Nov 8, 2024 · 1 comment
Open

Column names for length results in inconsistent behaviour #162

whelena opened this issue Nov 8, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@whelena
Copy link
Collaborator

whelena commented Nov 8, 2024

In the documentation it says

Multiple length values can be used together. All columns whose names contain length
will be used. (For example, length.1 and snv.length are both valid.)

This is true but I noted some inconsistent behaviour. Not sure if this is intentional, where to activate the automatic features a specific column name needs to be used (lenght.1 and length.2)

Example 1: Lengths specified using length.1 and length.2

Screenshot 2024-11-08 at 2 30 43 PM
Screenshot 2024-11-08 at 2 30 55 PM

Example 2: Lengths specified using snv.length and length.2

Y-axis is not generated for the first specified length (snv.length) and length.2' axis is moved to the left.
Screenshot 2024-11-08 at 2 31 50 PM

Example 3: Lengths specified using snv.length and length.3

Y-axis is not generated for snv.length and length.3 axis is generated to the left. Autp,ated edge colouring does not work, I'm assuming it's not generalized to take in column names other than length.2.
Screenshot 2024-11-08 at 2 33 28 PM

Example 4: Lengths specified using snv.length and pga.length

No y-axis or automated edge.colour.
Screenshot 2024-11-08 at 2 35 12 PM

@whelena whelena added the bug Something isn't working label Nov 8, 2024
@whelena
Copy link
Collaborator Author

whelena commented Nov 18, 2024

I think we should restrict column names to length.1 and length.2 for v3 until we can generalize it.

@whelena whelena closed this as completed Nov 18, 2024
@dan-knight dan-knight reopened this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants