Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent polygon behaviour when including CP column #138

Open
whelena opened this issue Aug 28, 2024 · 0 comments
Open

Inconsistent polygon behaviour when including CP column #138

whelena opened this issue Aug 28, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@whelena
Copy link
Collaborator

whelena commented Aug 28, 2024

I'm plotting single-sample SRC results using the fish-plot + tree feature. The data frame input looks like:

parent label length.1 CP
5 1 8 0.865
4 14 37 0.560
5 4 11 0.990
1 7 48 0.860
NA MRCA 122 0.930

Output plot :
Screenshot 2024-08-28 at 3 48 55 PM
I think this output is because CP of node 4 is greater than MRCA. But, this is also inconsistent with different CPs

CP 4 = 0.93 ($CP_4 = CP_{MRCA}$)

Screenshot 2024-08-28 at 3 52 01 PM

CP 4 = 0.8

Screenshot 2024-08-28 at 3 49 19 PM

CP 4 = 0.3 ($CP_4 < CP_14$)

Here the colour ordering is changed too
Screenshot 2024-08-28 at 3 55 40 PM

@dan-knight dan-knight added the bug Something isn't working label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants