Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine v and tree internal data structures #121

Open
dan-knight opened this issue Mar 8, 2024 · 0 comments
Open

Combine v and tree internal data structures #121

dan-knight opened this issue Mar 8, 2024 · 0 comments
Labels
future Planned future features refactor

Comments

@dan-knight
Copy link
Collaborator

dan-knight commented Mar 8, 2024

Related to #120

In clone.out, the node options and tree structure are separated into different dataframes. This can cause issues including:

  • Costly and inaccurate lookup (for example. tree[tree$tip == vi$id])
  • Inconsistency between index of each data.frame

Since these dataframes both seem to express the same concept - each row representing data for a single subclone - they can likely be combined. This will require further examination, but is worth a look.

@dan-knight dan-knight added the future Planned future features label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future Planned future features refactor
Projects
None yet
Development

No branches or pull requests

1 participant