Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge intersection style in nodeless mode #118

Open
dan-knight opened this issue Feb 13, 2024 · 6 comments
Open

Edge intersection style in nodeless mode #118

dan-knight opened this issue Feb 13, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request future Planned future features

Comments

@dan-knight
Copy link
Collaborator

dan-knight commented Feb 13, 2024

Without nodes, the intersection between edge line segments becomes visible. How should we handle this detail? Are there scientific considerations? For example, correctly "implying" the ancestor at the intersection point?

Screenshot 2024-02-13 at 12 24 03 PM
@dan-knight
Copy link
Collaborator Author

dan-knight commented Feb 13, 2024

Other considerations:

Varying line segment thickness
Screenshot 2024-02-13 at 12 43 56 PM

Varying line type
Screenshot 2024-02-13 at 12 45 35 PM

Multiple line segments
Screenshot 2024-02-13 at 1 58 09 PM

@dan-knight
Copy link
Collaborator Author

Possible Solutions

Parent on Top Layer
Grobs are stacked in the order that they are created, so the later line segments are rendered on top of the earlier ones. By reversing this, the parent will be rendered on top of its children. This results in an (almost) node at the tip of the parent line segment.
Screenshot 2024-02-13 at 1 07 39 PM

@dan-knight dan-knight added the enhancement New feature or request label Feb 14, 2024
@whelena
Copy link
Collaborator

whelena commented Feb 14, 2024

I might be missing the point of this issue, but what specifically are we considering here? Are you implying that there is a difference in how we would interpret the plot depending if the parent edge vs. children edge is on the front layer?

@dan-knight
Copy link
Collaborator Author

I don't think that the visual style was considered very much in the original design, since the node circles would hide this part of the plot. Now, nodeless mode will be more relevant when combined with dendrogram mode. Are there any major issues you can see here? General ugliness? It may just be the nature of these plots - something we leave for users to resolve given the amount of control the package allows.

@pboutros
Copy link

I think... at least for now, not a high priority issue. I view this as a graphical nicety rather than an error, and I think worth keeping this as an open feature request "find ways to improve visualization of segment boundaries in nodeless mode" kinda thing, but not worth stressing about right now as this is exposing features to users and allowing them to decide on optimal application.

@dan-knight
Copy link
Collaborator Author

I view this as a graphical nicety rather than an error

Sounds good. I don't think there's anything obvious that we should enforce as a default here. Certainly nothing we should enforce as a constraint. Thanks for the input everyone!

@dan-knight dan-knight added the future Planned future features label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request future Planned future features
Projects
None yet
Development

No branches or pull requests

3 participants