Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv-llvm bug fixes #43

Open
jeffy1009 opened this issue Apr 3, 2017 · 3 comments
Open

riscv-llvm bug fixes #43

jeffy1009 opened this issue Apr 3, 2017 · 3 comments

Comments

@jeffy1009
Copy link

Hello, I want to share the bug fixes for riscv-llvm and riscv-clang.

You can find the repository with the fixes applied at the following urls:
https://github.com/jeffy1009/riscv-llvm
https://github.com/jeffy1009/riscv-clang

llvm is based on commit 8713638
clang is based on commit 4cb8b5922c1abdf76bb3c0ed236ecb2fc44779d2
These commits are somewhere between LLVM 3.7 and 3.8.

The latest commits (merge with r275012/3) will break the build.
However, it should be easy to sync with LLVM 3.8.

Some of the fixes are not that pretty. (Please refer to the commit messages)

I could also create a pull request if I have permission (I believe I don't?)

@neuschaefer
Copy link
Contributor

AFAIK you don't need any special permissions to create a pull request on Github. I've never been unable to do it.

@jeffy1009
Copy link
Author

jeffy1009 commented Apr 4, 2017

Hmm.. if I try to create a pull request based on 8713638, "create pull request" button disappears. I guess a pull request should be based on a branch?

If someone create a branch from that commit I could create a pull request.
I can also sync with the trunk, but I don't have time for it now..

One more thing about the bug fixes.. It's been tested with RV64. I could run all of the SPEC2000 BMs(SPECINT). But it may still have issues with RV32.

@johan-bjareholt
Copy link

@jeffy1009 That is correct, you can only pull request to a branch and not a specific commit.

However, you can still create a pull request even though it cannot automatically merge, here's an example:
riscv-trunk...jeffy1009:jsshin

Even if you did this though the maintainer seems to be inactive so no one will be able to merge the pull request even if you do sync with riscv-trunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants