Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac ingester doesn't ingest the vertices and relationship #40

Open
hadisinaee opened this issue Jan 30, 2024 · 0 comments
Open

Mac ingester doesn't ingest the vertices and relationship #40

hadisinaee opened this issue Jan 30, 2024 · 0 comments
Assignees
Labels
bug Something isn't working platform:mac

Comments

@hadisinaee
Copy link
Collaborator

The current behaviour of the ingester is to read the index file and create two files:

  • Objects, which contain all the vertices.
  • Relationships, which contain all the relationships between Objects.

Then, we have to manually import these files into ADB.

The correct behaviour is that the ingester ingests all data and takes care of ingestions. There are cases which we should take care of:

  1. There are unique constraints. Therefore, we cannot re-ingest data. Therefore, for development, there should be a flag that lets us do it. It can be done by passing overwrite=True to the database. It should not be the default behaviour.
  2. We must not ingest relationships if the vertices ingestion fails.
@hadisinaee hadisinaee added enhancement New feature or request platform:mac labels Jan 30, 2024
@hadisinaee hadisinaee self-assigned this Jan 30, 2024
@hadisinaee hadisinaee added bug Something isn't working and removed enhancement New feature or request labels Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working platform:mac
Projects
None yet
Development

No branches or pull requests

1 participant