Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make IndalekoMachineConfig.py "do the right thing" by invoking the platform specific script #32

Open
fsgeek opened this issue Jan 21, 2024 · 2 comments
Open

Make IndalekoMachineConfig.py "do the right thing" by invoking the platform specific script #32

fsgeek opened this issue Jan 21, 2024 · 2 comments
Assignees
@fsgeek
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fsgeek
Copy link
Contributor

fsgeek commented Jan 21, 2024

Right now IndalekoMachineConfig.py just has test code. To make it easier to use this, we should add a single operator here that invokes the correct script for the given platform.

What this means is:

  • If there is a pre-data-gathering step required (e.g., to capture privileged data) this script should mention using it if the pre-requisite file doesn't exist.
  • If the pre-requisite (if any) is met, this should invoke the correct script, passing in the correct arguments.
  • The documentation in the README.md file should be updated.

This is a pretty small task, but it would simplify the UI for folks.
@fsgeek fsgeek added enhancement New feature or request good first issue Good for newcomers labels Jan 21, 2024
@fsgeek fsgeek self-assigned this Jan 21, 2024
fsgeek added a commit that referenced this issue Jan 21, 2024
@fsgeek
Issue #32 is about improving the machine config script. This change e…
4a01347 
…xplicitly talks about what to do for now, with hopes this will be fixed better in the future.
@fsgeek
Copy link
Contributor Author

fsgeek commented Jan 21, 2024

README.md description of the issue (and current approach) added in commit 4a01347.

@fsgeek
Copy link
Contributor Author

fsgeek commented Jan 21, 2024

There is an initial change for this that I introduced in commit d350acd. There's more to do here.

fsgeek added a commit that referenced this issue Jan 21, 2024
@fsgeek
This is the inital step to addressing Issue #32
d350acd
fsgeek added a commit that referenced this issue Jan 21, 2024
@fsgeek
Started fleshing out the interface for Issue #32 while working on #22.
3cc7eb3
fsgeek added a commit that referenced this issue Jan 22, 2024
@fsgeek
Add reference to Issue #32 in the README file.
af50ec8
@fsgeek fsgeek mentioned this issue Jan 22, 2024
Merged
hadisinaee added a commit that referenced this issue Jan 23, 2024
@fsgeek @hadisinaee
Consolidated changes for two issues (#34)
7722135 
* add mac machine config

- update readme with mac config setup
- add missing packages to the requirements.txt
- generate mac hardware info
- fix the query bug for getting machine config data

* Expand the README file

* add mac local indexer

* Issue #32 is about improving the machine config script.  This change explicitly talks about what to do for now, with hopes this will be fixed better in the future.

* This is the inital step to addressing Issue #32

* Add an additional logic check to ensure that the name captured exists.  See Issue #20 and #21.

* Started fleshing out the interface for Issue #32 while working on #22.

* Add reference to Issue #32 in the README file.

* Add more diagnostic information for Issue #20.

---------

Co-authored-by: Hadi (systopia-mac) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fsgeek fsgeek

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fsgeek