Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[git] list allowed formats to be synced within webapp or extend the list including sh scrips #431

Closed
danieltomasz opened this issue Sep 5, 2024 · 3 comments
Labels
feature request New feature or request.

Comments

@danieltomasz
Copy link

danieltomasz commented Sep 5, 2024

Description

I try to add my thesis (ported from markdown pandoc) to the typst and pull in the web-app.
Here is my repo:

image
When I tried to create new project from this git repository I got popup about unacceptable file format
Which format is not acceptable? sh? I use this as a git hook.

Use Case

Be more informative what kind of files are allowed/allows for more files.

@danieltomasz danieltomasz added the feature request New feature or request. label Sep 5, 2024
@danieltomasz danieltomasz changed the title [git] list of acceptable file format - repo with sh file prevented from being created in web-app [git] Cannot create project: The file is not in an acceptable format - doesn't give information which file format caused problems Sep 6, 2024
@danieltomasz danieltomasz changed the title [git] Cannot create project: The file is not in an acceptable format - doesn't give information which file format caused problems [git] Cannot create project: The file is not in an acceptable format - webapp doesn't give information which file format caused problems Sep 7, 2024
@danieltomasz danieltomasz changed the title [git] Cannot create project: The file is not in an acceptable format - webapp doesn't give information which file format caused problems [git] list allowed formats to be synced within webapp or extend the list including sh scrips Sep 17, 2024
@laurmaedje
Copy link
Member

Shell script files should be allowed and work in my testing. In your screenshot, I don't see any file format that would be disallowed. Without access to the repository, it's hard to tell what is going on.

PDF files are disallowed. Do you possibly have a PDF checked into your repo?

@danieltomasz
Copy link
Author

Thanks for the reply! The repos works now, sorry for unnecessary pinging you (so I will close it )

PDF are disallowed or just git ignored? I understand that adding every change in pdf might pollute the repo, but what if user want to manually add on their side a specific pdf (while pdf in general are gitignored)?

@laurmaedje
Copy link
Member

For UTF-8-decodable text files, we allow everything. For binary files there is an allow-list and that list doesn't include PDF, so it is strictly forbidden. This is not specific to Git integration, it's general to the web app. If you drag a PDF file into the app, it is auto-converted to SVG.

We are considering to allow more or potentially all file formats in the future, but that blocks on some internal things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request.
Projects
None yet
Development

No branches or pull requests

2 participants