Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammarly extension doesn't make changes to text #421

Closed
this-josh opened this issue Aug 21, 2024 · 5 comments
Closed

Grammarly extension doesn't make changes to text #421

this-josh opened this issue Aug 21, 2024 · 5 comments
Labels
bug Something isn't working. editor Related to the text/markup editor. upstream The issue is with the dependencies

Comments

@this-josh
Copy link

Description

When you select a Grammarly option the underlining goes, and the work is highlighted, but the change doesn't happen

Grammarly_typst.mov

I cannot see any errors in the console, and my Grammarly extension works fine in Overleaf - and this GitHub issue text box.

Reproduction URL

No response

Browsers

Chrome

OS

macOS

@this-josh this-josh added the bug Something isn't working. label Aug 21, 2024
@Enter-tainer
Copy link

sounds like "grammarly doesnt support typst"

@this-josh
Copy link
Author

It sounds like it, but I don't believe it is.

  • I know of no other site where this behaviour is exhibited
  • The Grammarly error checker and suggestion box are working correctly. It's just the text replacement, which isn't right

Without an error message, it is difficult to know which side the problem is, but given these two points, it seemed like a Typst word replacement issue.

@laurmaedje
Copy link
Member

See codemirror/dev#1416

@laurmaedje laurmaedje added upstream The issue is with the dependencies editor Related to the text/markup editor. labels Oct 11, 2024
@laurmaedje
Copy link
Member

Given the response by the author of CodeMirror, there is not much we can do. It appears to be an issue with Grammarly.

@laurmaedje laurmaedje closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2024
@Dherse
Copy link

Dherse commented Oct 11, 2024

Actually @laurmaedje, in the latest version of Chrome/typst/Grammarly: it works :)

Edit: I tested this like a week ago and it did not and now it does 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. editor Related to the text/markup editor. upstream The issue is with the dependencies
Projects
None yet
Development

No branches or pull requests

4 participants