-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with new modifier helper #570
Comments
For (1), do you have any examples that aren't using the For (2), unfortunately I think we may be fundamentally unable to make For the case you've linked there, have you considered using a single custom modifier to manage your event listeners? I suspect that would be easier to type, as well as avoiding runtime issues with emberjs/ember.js#19869 |
No, it seems to come up only with
I just tried that, and indeed it works nicely and avoids all the mentioned problems! Thanks for the suggestion! Gonna close this issue then, as it seems there isn't anything actionable left... |
Updating Glint to the new stable version 🎉 and removing my old
any
-based hacks due to the previously missing modifier-helper in this PR, I am seeing two issues come up here:Type instantiation is excessively deep and possibly infinite.
- this seems to be related to my use of a conditional modifier here, that error does not pop up when not using this patternExpected 1 arguments, but got 3.
- this seems to be also an edge case, when applying the modifier helper on the importedon
modifier (using@types/ember__modifier
, have not tried native types yet).{{modifier "on" ...}}
does not work due to [Bug] Theon
modifier does not work with themodifier
helper emberjs/ember.js#19869The text was updated successfully, but these errors were encountered: