Skip to content

Commit 57e66d6

Browse files
committed
Rip out commitlint from CI
There are better approaches available for solving this problem at this point, e.g. release-it and release-it-lerna-changelog plus use of tags on GitHub. Those approaches correctly place the burden on maintainers rather than on contributors.
1 parent dec5431 commit 57e66d6

File tree

5 files changed

+48
-1128
lines changed

5 files changed

+48
-1128
lines changed

Diff for: .github/PULL_REQUEST_TEMPLATE.md

+5-6
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
<!-- Thanks for submitting a pull request! 🎉 -->
1+
<!--
22
3-
<!-- Please note that commit messages need to follow the [Conventional Commits](https://www.conventionalcommits.org) format.
3+
Thanks for submitting a pull request! 🎉
44
5-
For example:
6-
test: fix node tests when run locally with ts-node
5+
Please include a link to a GitHub issue if one exists.
76
8-
-->
7+
If you don't hear from a maintainer within a few days, please feel free to ping us here or in #e-typescript on Discord!
98
10-
<!-- Also, please include a link to a github issue if one exists. -->
9+
-->

Diff for: .github/workflows/ci.yml

-16
Original file line numberDiff line numberDiff line change
@@ -20,22 +20,6 @@ env:
2020
CI: true
2121

2222
jobs:
23-
commitlint:
24-
name: Lint Commits
25-
runs-on: ubuntu-latest
26-
env:
27-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
28-
steps:
29-
- name: Checkout Code
30-
uses: actions/checkout@v2
31-
# We need the `with` argument here so that force pushes (e.g. from
32-
# Renovate rebasing) work correctly.
33-
# https://github.com/wagoid/commitlint-github-action/tree/d6a383492a776126bbeba8c1d797ead4baedaaae#usage
34-
with:
35-
fetch-depth: 0
36-
- name: Commitlint
37-
uses: wagoid/[email protected]
38-
3923
test-locked-deps:
4024
name: Test (linux, locked dependencies)
4125
runs-on: ubuntu-latest

Diff for: .vscode/launch.json

+3-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@
1111
"program": "${workspaceFolder}/node_modules/mocha/bin/_mocha",
1212
"args": [
1313
"-r", "register-ts-node",
14-
"-f", "generates .d.ts files when addon and package names do not match",
14+
"-f", "Acceptance: ember-cli-typescript generator",
15+
"-f", "basic app",
16+
"-t", "1000000",
1517
"ts/tests/**/*.{ts,js}"
1618
],
1719
"internalConsoleOptions": "openOnSessionStart"

Diff for: package.json

+1-12
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@
3535
"ci:test:app": "ember test",
3636
"ci:test:node": "mocha --recursive js/tests",
3737
"prepublishOnly": "yarn tsc --noEmit false --project ts",
38-
"postpublish": "rimraf js",
39-
"changelog": "conventional-changelog -p angular -i CHANGELOG.md -s -u"
38+
"postpublish": "rimraf js"
4039
},
4140
"dependencies": {
4241
"ansi-to-html": "^0.6.6",
@@ -51,8 +50,6 @@
5150
"walk-sync": "^2.2.0"
5251
},
5352
"devDependencies": {
54-
"@commitlint/cli": "11.0.0",
55-
"@commitlint/config-conventional": "11.0.0",
5653
"@ember/optional-features": "2.0.0",
5754
"@glimmer/component": "^1.0.0-beta.3",
5855
"@glimmer/tracking": "^1.0.0-beta.3",
@@ -82,8 +79,6 @@
8279
"broccoli-plugin": "4.0.3",
8380
"capture-console": "1.0.1",
8481
"co": "4.6.0",
85-
"commitlint-azure-pipelines-cli": "1.0.3",
86-
"conventional-changelog-cli": "2.1.1",
8782
"ember-cli": "3.22.0",
8883
"ember-cli-app-version": "4.0.0",
8984
"ember-cli-babel": "7.23.0",
@@ -112,7 +107,6 @@
112107
"fixturify": "2.1.0",
113108
"got": "11.8.0",
114109
"handlebars": "4.7.7",
115-
"husky": "4.3.0",
116110
"in-repo-a": "link:tests/dummy/lib/in-repo-a",
117111
"in-repo-b": "link:tests/dummy/lib/in-repo-b",
118112
"loader.js": "4.7.0",
@@ -139,11 +133,6 @@
139133
"broccoli-watcher"
140134
]
141135
},
142-
"husky": {
143-
"hooks": {
144-
"commit-msg": "commitlint -E HUSKY_GIT_PARAMS"
145-
}
146-
},
147136
"prettier": {
148137
"printWidth": 100,
149138
"semi": true,

0 commit comments

Comments
 (0)