-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animation on repeat speeds up over time. #378
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Interesting, at least that behavior is consistently repeating, rather than changing each time it repeats. Let's see what's going on here.. |
@trusktr It is about tween.js or es6-tween. I am added this to es6-tween issue list and i will fix as soon as possible |
Looks like the examples broke. I update the OP with a working example on codepen. I'd like to start fixing stuff and moving forward! |
@dalisoft Mind updating your example? Also, sidenote, if you don't mind making some PRs to bring your ideas into the main repo, that'd be great! |
@trusktr I updated, but seems does not work, some incompatibility with two.js I deprecated es6-tween due of less time to spent, i think these some things can be applied and source code can be got from es6-tween
|
@dalisoft Thanks! I updated your example with the working version of Two.js: https://codepen.io/trusktr/pen/b10d7a5693b7ba6b9ed70b13e7ab0fb2?editors=1010 I like those ideas. In particular I'm curious about Interested to learn about the alternative method. I'm thinking perhaps to cache the nested objects to key paths. What'd you do in es6-tween? |
Updated the broken example with newest changes. No luck though: https://codepen.io/trusktr/pen/c258027326d412f81e3aad96d669307c?editors=1010 Need to dig into it... |
@dalisoft In which commit did you fix the bug in es6-tween? |
@trusktr Which bug? I don’t remember, there but more commits, really I don’t have time to checkout all them. |
I meant the bug that the above demo goes faster and faster over time. I'll peruse through es6-tween next. |
I don’t think i can support es6-tween anymore currently and within few month. |
Looks like this is still reproducible in v22, and in particular it looks like it happens with the new https://codepen.io/trusktr/pen/oNVBjKG/ff650c9a627e22bb629cdae20b8eaec4?editors=1010 When using the current |
Here's @jonobr1's original, forked to use array values:
https://codepen.io/trusktr/pen/04518ee24a8d1d7822e584c6a513d378?editors=1010
Watch it for a while. Over time, the animation speeds up, which shouldn't happen.
The text was updated successfully, but these errors were encountered: