Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation on repeat speeds up over time. #378

Open
trusktr opened this issue Sep 17, 2017 · 17 comments
Open

Animation on repeat speeds up over time. #378

trusktr opened this issue Sep 17, 2017 · 17 comments
Labels

Comments

@trusktr
Copy link
Member

trusktr commented Sep 17, 2017

Here's @jonobr1's original, forked to use array values:

https://codepen.io/trusktr/pen/04518ee24a8d1d7822e584c6a513d378?editors=1010

Watch it for a while. Over time, the animation speeds up, which shouldn't happen.

@jonobr1

This comment has been minimized.

@trusktr

This comment has been minimized.

@trusktr trusktr changed the title Why does this fiddle not work? Animation on repeat speeds up over time. Sep 17, 2017
@trusktr trusktr added the Bug label Sep 17, 2017
@jonobr1

This comment has been minimized.

@dalisoft
Copy link
Collaborator

dalisoft commented Sep 19, 2017

@trusktr See fiddle using es6-tween, but it has bug also

EDIT: I fixed bug

@trusktr
Copy link
Member Author

trusktr commented Sep 19, 2017

Interesting, at least that behavior is consistently repeating, rather than changing each time it repeats. Let's see what's going on here..

@dalisoft
Copy link
Collaborator

@trusktr It is about tween.js or es6-tween. I am added this to es6-tween issue list and i will fix as soon as possible

@dalisoft
Copy link
Collaborator

@trusktr Is in this fiddle issue was fixed?

@trusktr
Copy link
Member Author

trusktr commented May 30, 2020

Looks like the examples broke. I update the OP with a working example on codepen. I'd like to start fixing stuff and moving forward!

@trusktr
Copy link
Member Author

trusktr commented May 30, 2020

@dalisoft Mind updating your example?

Also, sidenote, if you don't mind making some PRs to bring your ideas into the main repo, that'd be great!

@dalisoft
Copy link
Collaborator

@trusktr I updated, but seems does not work, some incompatibility with two.js

I deprecated es6-tween due of less time to spent, i think these some things can be applied and source code can be got from es6-tween

  • TypeScript (currently es6-tween is ES6, but before have been written TS)
  • DOM Plugins
  • Infinite Deep-Level tweening without loss of performance
  • Events (multiple .on('complete' | 'update', 'start'))

@trusktr
Copy link
Member Author

trusktr commented Jun 1, 2020

@dalisoft Thanks! I updated your example with the working version of Two.js: https://codepen.io/trusktr/pen/b10d7a5693b7ba6b9ed70b13e7ab0fb2?editors=1010

I like those ideas. In particular I'm curious about Infinite Deep-Level tweening without loss of performance. I just merged and updated outstanding nested properties pull requests from @Malows and @talltyler. See #536 and #366

Interested to learn about the alternative method. I'm thinking perhaps to cache the nested objects to key paths. What'd you do in es6-tween?

@trusktr
Copy link
Member Author

trusktr commented Jun 1, 2020

Updated the broken example with newest changes. No luck though: https://codepen.io/trusktr/pen/c258027326d412f81e3aad96d669307c?editors=1010 Need to dig into it...

@trusktr
Copy link
Member Author

trusktr commented Jun 1, 2020

@dalisoft In which commit did you fix the bug in es6-tween?

@dalisoft
Copy link
Collaborator

dalisoft commented Jun 1, 2020

@trusktr Which bug? I don’t remember, there but more commits, really I don’t have time to checkout all them.
Of course, if you mean infinite deep level tweening - it’s not bug, i made it feature from start of planning es6-tween.
Most of tweening library still does not support this feature

@trusktr
Copy link
Member Author

trusktr commented Jun 3, 2020

I meant the bug that the above demo goes faster and faster over time. I'll peruse through es6-tween next.

@dalisoft
Copy link
Collaborator

dalisoft commented Jun 3, 2020

I don’t think i can support es6-tween anymore currently and within few month.
Of course, it’s off-topic, but did you got my mail message?

@trusktr trusktr linked a pull request Apr 23, 2023 that will close this issue
@trusktr
Copy link
Member Author

trusktr commented Jan 15, 2024

Looks like this is still reproducible in v22, and in particular it looks like it happens with the new startFromCurrentValues() method which used to be the default behavior in v16.6:

https://codepen.io/trusktr/pen/oNVBjKG/ff650c9a627e22bb629cdae20b8eaec4?editors=1010

When using the current .start() method in recent tween.js version, the issue is bypassed. This provides a clue: it has to do with starting with current values!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants