PacketIndex is increased even when userdata didn't change

[zapek]

When a packet is received, packet_index is checked for increments to see if the userdata needs to be updated:

udp-discovery-cpp/udp_discovery_peer.cpp

Line 351 in 63eda22

bool update_user_data = ((*find_it).last_received_packet() < header.packet_index);

But here:

udp-discovery-cpp/udp_discovery_peer.cpp

Line 397 in 63eda22

++packet_index_;

packet_index is incremented everytime a packet is sent, even if the userdata didn't change.

Shouldn't it be increased only if the userdata changed?

[truvorskameikin]

That is a good idea to not increment packet_index every send. And I think that it also can be renamed to something like snapshot_index. Now it should increase on every user_data change.