feat(common): BREAKING CHANGE refactor add-on system #31167
Draft
+1,079
−1,013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview ready!
|
PrivatePuffin
changed the title
PrivatePuffin
commented
Jan 25, 2025
PrivatePuffin
commented
Jan 25, 2025
PrivatePuffin
commented
Jan 25, 2025
PrivatePuffin
commented
Jan 25, 2025
PrivatePuffin
commented
Jan 25, 2025
PrivatePuffin
changed the title
PrivatePuffin
requested review from
alfi0812,
kqmaverick,
Heavybullets8,
StevenMcElligott and
xstar97
as code owners
PrivatePuffin
commented
Jan 30, 2025
PrivatePuffin
commented
Jan 30, 2025
PrivatePuffin
commented
Jan 30, 2025
PrivatePuffin
commented
Jan 30, 2025
PrivatePuffin
commented
Jan 30, 2025
PrivatePuffin
commented
Jan 31, 2025
charts/library/common/templates/addons/code-server/_codeserver.tpl
Outdated
Show resolved
Hide resolved
PrivatePuffin
commented
Jan 31, 2025
charts/library/common/templates/addons/code-server/_codeserver.tpl
Outdated
Show resolved
Hide resolved
PrivatePuffin
commented
Jan 31, 2025
charts/library/common/templates/addons/code-server/_codeserver.tpl
Outdated
Show resolved
Hide resolved
PrivatePuffin
force-pushed
the
new-common
branch
from
fb0aad2 to
5f57c4b
Compare
2 tasks
PrivatePuffin
force-pushed
the
new-common
branch
from
3455cde to
3ded286
Compare
remove old addon system completely bump versions initial mariadb example seperate addons and dependencies add resources support to addons Make it a feature instead of a breaking fix rootctx oopsie initial work on codeserver fixup netshoot some tweaks/fixes more vpn work more vpn work more TODOs added to dependency stuff Apply suggestions from code review Signed-off-by: Kjeld Schouten <[email protected]> Update _netshoot.tpl Signed-off-by: Kjeld Schouten <[email protected]> Update _netshoot.tpl Signed-off-by: Kjeld Schouten <[email protected]> Update charts/library/common/templates/addons/vpn/_vpn.tpl Signed-off-by: Kjeld Schouten <[email protected]> Update _codeserver.tpl Signed-off-by: Kjeld Schouten <[email protected]> Update charts/library/common/templates/addons/vpn/_vpn.tpl Signed-off-by: Kjeld Schouten <[email protected]> Update charts/library/common/templates/addons/vpn/_vpn.tpl Signed-off-by: Kjeld Schouten <[email protected]> Update charts/library/common/templates/addons/vpn/_vpn.tpl Signed-off-by: Kjeld Schouten <[email protected]> Update charts/library/common/templates/addons/vpn/_vpn.tpl Signed-off-by: Kjeld Schouten <[email protected]> Update _codeserver.tpl Signed-off-by: Kjeld Schouten <[email protected]> Update charts/library/common/templates/addons/code-server/_codeserver.tpl Signed-off-by: Kjeld Schouten <[email protected]> Update _codeserver.tpl Signed-off-by: Kjeld Schouten <[email protected]> Update values.yaml Signed-off-by: Kjeld Schouten <[email protected]> basic new structure actually load new vpn addon locations cleanup references remove old openvpn and wireguard Delete charts/library/common-test/ci/vpn-wireguard-values.yaml Signed-off-by: Kjeld Schouten <[email protected]> Delete charts/library/common-test/ci/vpn-openvpn-values.yaml Signed-off-by: Kjeld Schouten <[email protected]> Delete containers/apps/wireguard directory Signed-off-by: Kjeld Schouten <[email protected]> Delete containers/apps/openvpn-client directory Signed-off-by: Kjeld Schouten <[email protected]>
PrivatePuffin
force-pushed
the
new-common
branch
from
3ded286 to
fddee4d
Compare
Signed-off-by: Stavros Kois <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the add-on system to allow for more end-user flexibility
It basically moves add-on container configuration to values.yaml, to expose all container options to end users.
Fixes: #27351
Fixes: #31876
⚙️ Type of change
🧪 How Has This Been Tested?
📃 Notes:
✔️ Checklist:
feat(chart-name):,fix(chart-name):orchore(chart-name):➕ App addition
If this PR is an app addition please make sure you have done the following.
icon.pngPlease don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.