Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ifpack2: Kokkos Kernels expecting to deprecate KOKKOS_CUSPARSE_SAFE_CALL #13596

Open
cwpearson opened this issue Nov 13, 2024 · 2 comments
Open

Ifpack2: Kokkos Kernels expecting to deprecate KOKKOS_CUSPARSE_SAFE_CALL #13596

cwpearson opened this issue Nov 13, 2024 · 2 comments
Assignees
@cwpearson
Labels
pkg: Ifpack2

Comments

@cwpearson
Copy link
Contributor

cwpearson commented Nov 13, 2024 •
edited
Loading

Trilinos/packages/ifpack2/src/Ifpack2_LocalSparseTriangularSolver_def.hpp

Lines 678 to 679 in b3df351

KOKKOS_CUSPARSE_SAFE_CALL(
cusparseSetStream(cusparse_handle->handle, exec_space_instances_[i].cuda_stream()));

kokkos/kokkos-kernels#2426

Kokkos Kernels doesn't expect to maintain a corresponding public interface going forward.

I can make a PR to bring the implementation of this macro into Ifpack2 if that would be accepable?
@cwpearson cwpearson self-assigned this Nov 13, 2024
@github-actions GitHub Actions
Copy link

Automatic mention of the @trilinos/ifpack2 team

1 similar comment
@github-actions GitHub Actions
Copy link

Automatic mention of the @trilinos/ifpack2 team

@cwpearson cwpearson changed the title Ifpack2: Kokkos Kernels expecting to deprecate KOKKOSPARSE_IMPL_CUSPARSE_SAFE_CALL Ifpack2: Kokkos Kernels expecting to deprecate KOKKOS_CUSPARSE_SAFE_CALL Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwpearson cwpearson

Labels
pkg: Ifpack2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cwpearson