Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails with clang-19: no member named 'sort_option' in 'SPADDHandle<lno_row_view_t_, lno_nnz_view_t_, scalar_nnz_view_t_, ExecutionSpace, MemorySpace>' #13570

Open
yurivict opened this issue Nov 4, 2024 · 5 comments
Labels
PA: Framework Issues that fall under the Trilinos Framework Product Area pkg: KokkosKernels type: bug The primary issue is a bug in Trilinos code or tests

Comments

@yurivict
Copy link

yurivict commented Nov 4, 2024

In file included from /wrkdirs/usr/ports/science/trilinos/work/.build/packages/kokkos-kernels/graph/eti/generated_specializations_cpp/color_d1/Graph_color_d1_eti_DOUBLE_ORDINAL_INT_OFFSET_SIZE_T_LAYOUTLEFT_EXECSPACE_SERIAL_MEMSPACE_HOSTSPACE.cpp:21:
In file included from /wrkdirs/usr/ports/science/trilinos/work/Trilinos-trilinos-release-16-0-0/packages/kokkos-kernels/graph/impl/KokkosGraph_color_d1_spec.hpp:22:
In file included from /wrkdirs/usr/ports/science/trilinos/work/Trilinos-trilinos-release-16-0-0/packages/kokkos-kernels/sparse/src/KokkosKernels_Handle.hpp:21:
/wrkdirs/usr/ports/science/trilinos/work/Trilinos-trilinos-release-16-0-0/packages/kokkos-kernels/sparse/src/KokkosSparse_spadd_handle.hpp:113:44: error: no member named 'sort_option' in 'SPADDHandle<lno_row_view_t_, lno_nnz_view_t_, scalar_nnz_view_t_, ExecutionSpace, MemorySpace>'
  113 |   void set_sort_option(int option) { this->sort_option = option; }
      |                                      ~~~~  ^
/wrkdirs/usr/ports/science/trilinos/work/Trilinos-trilinos-release-16-0-0/packages/kokkos-kernels/sparse/src/KokkosSparse_spadd_handle.hpp:115:40: error: no member named 'sort_option' in 'SPADDHandle<lno_row_view_t_, lno_nnz_view_t_, scalar_nnz_view_t_, ExecutionSpace, MemorySpace>'
  115 |   int get_sort_option() { return this->sort_option; }
      |                                  ~~~~  ^

Version: 16.0.0
clang-19
FreeBSD 14.1

@yurivict yurivict added the type: bug The primary issue is a bug in Trilinos code or tests label Nov 4, 2024
@cgcgcg
Copy link
Contributor

cgcgcg commented Nov 4, 2024

FYI kokkos/kokkos-kernels#2347

@yurivict
Copy link
Author

yurivict commented Nov 4, 2024

It seems like Trilinos has bundled the kokkos project and this bug is in the bundled kokkos.

@cgcgcg
Copy link
Contributor

cgcgcg commented Nov 4, 2024

Looks like it's fixed on develop.

@trilinos/framework Maybe we should consider a minor release with the fix from KokkosKernels?

@cgcgcg cgcgcg added pkg: KokkosKernels PA: Framework Issues that fall under the Trilinos Framework Product Area labels Nov 4, 2024
@brian-kelley
Copy link
Contributor

brian-kelley commented Nov 6, 2024

@cgcgcg This fix is included in the KokkosKernels 4.5 release which will be merged very soon, so maybe there can be a Trilinos release right after that.

@brian-kelley
Copy link
Contributor

Actually never mind, this fix has been patched in develop for a while: #13403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PA: Framework Issues that fall under the Trilinos Framework Product Area pkg: KokkosKernels type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Development

No branches or pull requests

3 participants