You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are a 15 files in ROL/src that use the "using namespace std" (anti-)pattern. I noticed this when compiling with clang 17.
My compiler mostly complained about unqualified use of std::forward in one file (ROL_VectorClone.hpp). But there might be other places where unqualified standard library functions are used.
Does anyone have objections to me removing the "using namespace std;" lines and making things explicit, as needed?
The text was updated successfully, but these errors were encountered:
These are have all been fixed in the ROL development branch so it's just a matter of merging to Trilinos.
I wrote a clang-tidy check that can either automatically replace using namespace foo with using foo::bar in the same location for every bar symbol used or alternatively prepend all of the symbols with the appropriate foo:: namespace qualifier if that is of any interest.
There are a 15 files in ROL/src that use the "using namespace std" (anti-)pattern. I noticed this when compiling with clang 17.
My compiler mostly complained about unqualified use of
std::forward
in one file (ROL_VectorClone.hpp). But there might be other places where unqualified standard library functions are used.Does anyone have objections to me removing the "using namespace std;" lines and making things explicit, as needed?
The text was updated successfully, but these errors were encountered: