MueLu: Code on 'develop' fails clang-format check breaking every PR starting 2024-10-10

[bartlettroscoe]

Bug Report

Somehow, MueLu code on 'develop' is failing the clang-format check for PRs that don't touch MueLu. For example, for the PR:

• TriBITS: Transition to find_package(Python3) (TriBITSPub/TriBITS#610) #13523

which does not touch any clang-format settings or file under packages/muelu, the clang-format GHA check fails:

• https://github.com/trilinos/Trilinos/actions/runs/11284214857/job/31385051962?pr=13523

showing the diff:

diff --git a/packages/muelu/test/unit_tests/IntrepidPCoarsenFactory.cpp b/packages/muelu/test/unit_tests/IntrepidPCoarsenFactory.cpp
index 6a1082a1..c324c1cc 100644
--- a/packages/muelu/test/unit_tests/IntrepidPCoarsenFactory.cpp
+++ b/packages/muelu/test/unit_tests/IntrepidPCoarsenFactory.cpp
@@ -48,7 +48,7 @@ namespace MueLuTests {
 #ifndef TEST_MORE_COMBINATIONS
 static const int MAX_LINE_DEGREE = (Intrepid2::Parameters::MaxOrder < 10) ? Intrepid2::Parameters::MaxOrder : 10;
 static const int MAX_QUAD_DEGREE = (Intrepid2::Parameters::MaxOrder < 10) ? Intrepid2::Parameters::MaxOrder : 10;
-static const int MAX_HEX_DEGREE  = (Intrepid2::Parameters::MaxOrder < 4) ? Intrepid2::Parameters::MaxOrder  :  4;
+static const int MAX_HEX_DEGREE  = (Intrepid2::Parameters::MaxOrder < 4) ? Intrepid2::Parameters::MaxOrder : 4;
 static const int MAX_RANK_COUNT  = 4;
 #else
 static const int MAX_LINE_DEGREE = Intrepid2::Parameters::MaxOrder;

As shown here:

• https://github.com/trilinos/Trilinos/actions/workflows/clang_format.yml

all of these checks have failed for every PR for the last 2 hours impacting the PRs:

• TriBITS: Transition to find_package(Python3) (TriBITSPub/TriBITS#610) #13523
• MueLu: Refactor CoalesceDropFactory_kokkos #13361

How did this happen?

[github-actions]

Automatic mention of the @trilinos/muelu team

[github-actions]

Automatic mention of the @trilinos/muelu team

[bartlettroscoe]

Looking at the commit history for the file packages/muelu/test/unit_tests/IntrepidPCoarsenFactory.cpp, it looks like the commit 6a817df caused this.

How did that commit get onto the 'develop' branch? @sebrowne?

[cgcgcg]

The problem is that the clang check has not been marked as required. Fortunately this also means that it won't block any PRs from merging now.

[bartlettroscoe]

The problem is that the clang check has not been marked as required. Fortunately this also means that it won't block any PRs from merging now.

They why are we getting emails about this? Non-required checks should not be triggering notifications.

Update: I guess I am just confused why the Trilinos GH repo would be configured to send out failure notifications for failing GHA checks that the PR author can do nothing to fix. Is this just not conditioning developers to ignore the GHA failures?

[cgcgcg]

@trilinos/framework Can we switch the clang-format check to "Required" to avoid this in the future?