Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kokkos-kernels: gemm fails on host Views with rocBLAS enabled #13470

Open
japlews opened this issue Sep 24, 2024 · 3 comments
Open

kokkos-kernels: gemm fails on host Views with rocBLAS enabled #13470

japlews opened this issue Sep 24, 2024 · 3 comments
Labels
pkg: KokkosKernels type: bug The primary issue is a bug in Trilinos code or tests

Comments

@japlews
Copy link
Contributor

japlews commented Sep 24, 2024

Bug Report

We are seeing this in Sierra builds. Compile with HIP and rocBLAS, and the below code fails to build. It attempts to run on the device, despite that execution_space is Kokkos::Serial. Here's a MRE:

TEST(KokkosGEMMBug, hipEnabledGemmHostViewFails) {
    using ExecSpace = Kokkos::DefaultHostExecutionSpace;
    const double alpha = 1.0;
    const double beta = 0.0;
    Kokkos::View<double*, ExecSpace> a, b, c;
    KokkosBlas::gemm("N", "N", alpha, b, c, beta, a);
}

It looks like there is some compile-time checking missing in KokkosKernels Level 3 BLAS...

@japlews japlews added the type: bug The primary issue is a bug in Trilinos code or tests label Sep 24, 2024
@japlews
Copy link
Contributor Author

japlews commented Sep 24, 2024

@lucbv can you confirm whether this issue is still in Kokkos Kernels itself?

@csiefer2
Copy link
Member

@cwpearson

@lucbv
Copy link
Contributor

lucbv commented Sep 24, 2024

I am having a look at this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: KokkosKernels type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Development

No branches or pull requests

4 participants