Skip to content

Commit 15c4a28

Browse files
authored
Merge branch 'main' into 3.12
2 parents b775402 + b8f785f commit 15c4a28

File tree

6 files changed

+2118
-1586
lines changed

6 files changed

+2118
-1586
lines changed

poetry.lock

+2,094-1,561
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

+12-11
Original file line numberDiff line numberDiff line change
@@ -11,42 +11,43 @@ packages = [
1111

1212
[tool.poetry.dependencies]
1313
python = ">=3.8,<4"
14-
PyYAML = ">=5.0"
14+
PyYAML = { version = "!=6.0.0,!=5.4.0,!=5.4.1" }
1515
Jinja2 = ">=2.10.3"
1616

1717
# For unit tests
1818
boto3-stubs = {version = ">=1.24.17", extras = ["s3"]}
1919

2020
# optional dependencies
21-
google-cloud-storage = { version = ">=2.0.0", optional = true }
22-
psycopg2 = { version = ">=2.9.3", optional = true }
23-
SQLAlchemy = { version = ">=1.4.31", optional = true }
24-
dbt-core = { version = ">=1.4", optional = true }
25-
dbt-bigquery = { version = ">=1.1", optional = true }
26-
google-cloud-bigquery = { version = ">=2.0", optional = true }
27-
protobuf = { version = ">=3.20.2", optional = true }
2821
boto3 = { version = ">=1.24.14", optional = true }
22+
dbt-adapters = { version = "~1.1.1", optional = true }
23+
dbt-bigquery = { version = ">=1.8", optional = true }
24+
dbt-core = { version = ">=1.8", optional = true }
25+
google-cloud-bigquery = { version = ">=3.0", optional = true }
26+
google-cloud-storage = { version = ">=2.0", optional = true }
27+
protobuf = { version = ">=3.20.2", optional = true }
28+
psycopg2 = { version = ">=2.9.3", optional = true }
2929
rsa = { version = ">=4.7", optional = true }
30+
SQLAlchemy = { version = ">=2.0", optional = true }
3031

3132
# To avoid not in poetry.lock metadata
3233
networkx = { version = ">=2.3,<2.8.1", optional = true }
3334

3435
[tool.poetry.extras]
36+
dbt-bigquery = ["dbt-adapters", "dbt-core", "dbt-bigquery", "google-cloud-bigquery", "protobuf", "networkx", "rsa"]
3537
gcs = ["google-cloud-storage", "protobuf", "rsa"]
3638
redash = ["psycopg2", "SQLAlchemy"]
37-
dbt-bigquery = ["dbt-core", "dbt-bigquery", "google-cloud-bigquery", "protobuf", "networkx", "rsa"]
3839
s3 = ["boto3", "boto3-stubs"]
3940

4041
[tool.poetry.dev-dependencies]
4142
black = ">=22.3.0"
4243
flake8 = ">=4.0.1"
4344
isort = ">=5.9.3"
45+
moto = {extras = ["s3"], version = ">=3.1.16"}
4446
mypy = ">=0.961"
45-
types-PyYAML = ">=6.0.8"
4647
pytest = ">=7.2.0"
4748
pytest-cov = ">=4.0.0"
4849
pytest-mock = ">=3.8.1"
49-
moto = {extras = ["s3"], version = ">=3.1.16"}
50+
types-PyYAML = ">=6.0.8"
5051

5152
[tool.poetry.scripts]
5253
stairlight = "src.stairlight.cli:main"

src/stairlight/source/redash/template.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ def get_template_str(self) -> str:
6767

6868
def get_uri(self) -> str:
6969
"""Get uri"""
70-
return super().get_uri()
70+
return self.uri
7171

7272

7373
class RedashTemplateSource(TemplateSource):

src/stairlight/source/template.py

+4-6
Original file line numberDiff line numberDiff line change
@@ -196,24 +196,22 @@ def render_by_string_template(
196196

197197
try:
198198
rendered_str = s.substitute(params)
199-
except KeyError as e:
199+
except KeyError:
200200
logger.warning(
201201
(
202-
f"{e.with_traceback}, "
202+
f"Params not found; "
203203
f"source_type: {self.source_type}, "
204204
f"key: {self.key}",
205-
f"template_str: {template_str}",
206205
f"params: {params}",
207206
)
208207
)
209208
rendered_str = s.safe_substitute(params)
210-
except ValueError as e:
209+
except ValueError:
211210
logger.warning(
212211
(
213-
f"{e.with_traceback}, "
212+
f"Query rendering failed; "
214213
f"source_type: {self.source_type}, "
215214
f"key: {self.key}",
216-
f"template_str: {template_str}",
217215
f"params: {params}",
218216
)
219217
)

src/stairlight/stairlight.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -505,9 +505,9 @@ def search_verbose(
505505
next_table_name
506506
]
507507
if next_response[next_table_name][direction.value]:
508-
search_results[next_table_name][
509-
direction.value
510-
] = next_response[next_table_name][direction.value]
508+
search_results[next_table_name][direction.value] = (
509+
next_response[next_table_name][direction.value]
510+
)
511511
else:
512512
search_results[table_name]["Templates"].append(template)
513513

tests/stairlight/source/s3/test_template.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
import boto3
66
import pytest
7-
from moto import mock_s3
7+
from moto import mock_aws
88

99
from src.stairlight.configurator import Configurator
1010
from src.stairlight.source.config import (
@@ -74,7 +74,7 @@ def test_get_uri(
7474
):
7575
assert s3_template.uri == f"{S3_URI_SCHEME}{bucket}/{key}"
7676

77-
@mock_s3
77+
@mock_aws
7878
def test_get_jinja_params(
7979
self,
8080
s3_template: S3Template,
@@ -95,7 +95,7 @@ def test_get_jinja_params_integration(
9595
template_str = s3_template.get_template_str()
9696
assert len(s3_template.get_jinja_params(template_str)) > 0
9797

98-
@mock_s3
98+
@mock_aws
9999
def test_render(
100100
self,
101101
s3_template: S3Template,
@@ -143,7 +143,7 @@ def s3_template_source(
143143
include=_include,
144144
)
145145

146-
@mock_s3
146+
@mock_aws
147147
def test_search_templates(self, s3_template_source: S3TemplateSource):
148148
s3_client = boto3.resource("s3", region_name="us-east-1")
149149
s3_client.create_bucket(Bucket=BUCKET_NAME)

0 commit comments

Comments
 (0)