Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small typo in README #119

Open
k0nG opened this issue Dec 14, 2021 · 1 comment
Open

Small typo in README #119

k0nG opened this issue Dec 14, 2021 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@k0nG
Copy link

k0nG commented Dec 14, 2021

Under https://github.com/torchbox/wagtail-wordpress-import#first-steps-to-configure-your-wagtail-app

It's intended that these fields are temporary for while importing, and can be removed once the content has been imported.

Maybe should read:

It's intended that these fields are temporary while importing, and can be removed once the content has been imported.

@nimasmi
Copy link
Collaborator

nimasmi commented Dec 14, 2021

That would change the meaning to be wrong. The fields are temporary. The fields are for use while importing. They don't become permanent when you have finished importing. Therefore although it is not false to say that they are "temporary while importing", it is similar to saying that "seatbelts are provided when you are in a crashing car", rather than that they are always provided for when you are in a crashing car.

Perhaps the message isn't clear. What wording would make this clearer?

@nickmoreton nickmoreton added bug Something isn't working documentation Improvements or additions to documentation and removed bug Something isn't working labels Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants