Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The footnotes modal URL is not behind any authentication #18

Open
mixxorz opened this issue Jul 19, 2021 · 2 comments
Open

The footnotes modal URL is not behind any authentication #18

mixxorz opened this issue Jul 19, 2021 · 2 comments

Comments

@mixxorz
Copy link

mixxorz commented Jul 19, 2021

I can access /footnotes/footnotes_modal/ without logging in.
@jsma
Copy link
Contributor

jsma commented Feb 24, 2022

No data is exposed, only the basic HTML for the modal is returned so it is essentially a static file (if the {% comment %} tag was removed, it literally could be a static HTML file), so I'm not sure authentication should be required here.

@nickmoreton
Copy link
Contributor

I think it's worth looking into it further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsma @nickmoreton @mixxorz