Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox Benchmark TypeScript FPS wrong / halved? #308

Open
vjancik opened this issue Dec 1, 2019 · 3 comments
Open

Firefox Benchmark TypeScript FPS wrong / halved? #308

vjancik opened this issue Dec 1, 2019 · 3 comments
Assignees
Labels
Benchmark Bugs concerning the Benchmarking WasmBoy App bug Something isn't working

Comments

@vjancik
Copy link

vjancik commented Dec 1, 2019

It looks like Firefox thinks it ran 5000 frames, despite 2500 being specified, then the resultant FPS for TS and TS + Clojure looks about half of that on Chrome.

That or JS execution on Firefox really is half as fast as on Chrome?

FirefoxPerf
ChromePerf

@torch2424 torch2424 self-assigned this Dec 2, 2019
@torch2424 torch2424 added Benchmark Bugs concerning the Benchmarking WasmBoy App bug Something isn't working labels Dec 2, 2019
@torch2424
Copy link
Owner

@vjancik Hello! Thank you for the issue! 😄

So I went ahead and tested this and got the following:

FireFox:

Screen Shot 2019-12-02 at 11 26 47 AM

Chrome:

Screen Shot 2019-12-02 at 11 26 30 AM

So I got it so that they both run the correct number of frames? Did you perhaps change it to 5000, and then rerun again? And what operating system are you using? 🤔

Thank you very much! 😄

@vjancik
Copy link
Author

vjancik commented Dec 6, 2019

The OS is in the screenshot. But the number of frames isn't necessarily the issue.
The issue is that the JS performance on Firefox shouldn't be 50% of that on Chrome?
Unless this is a task that Firefox just has a really hard time optimizing for?

@torch2424
Copy link
Owner

Ah so yes! Firefox did have a hard time optimizing for this, I ended up getting an issue / some outreach from some awesome folks from Mozilla in #216

I know the bug was fixed (both on my end and theirs) but it may still have something to do with that? 🤔

If I may ask, do you know another benchmark of Chrome vs. Firefox performance I can look into? 😀

Thanks again! Looking forward to looking deeper into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark Bugs concerning the Benchmarking WasmBoy App bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants