fix: disable msbuild.exe nodeReuse

tmm1 · tmm1 · commit 5d9beef84f54 · 2024-12-29T05:47:42.000-08:00
On windows, one may experience errors due to concurrent node-gyp calls (see nodejs#3095) When retrying after such a failure, retries are observed to fail repeatedly with strange EBUSY and EPERM errors. This turns out to be due to a caching feature where msbuild.exe will continue to run in the background (for either 15s or 15m depending on VS version), and keep open file handles to files and directories that the user may be trying to delete (for example with a new call to `npm ci`). This behavior is well documented, as is the recommended workaround implemented here.
diff --git a/lib/build.js b/lib/build.js
@@ -141,6 +141,8 @@ async function build (gyp, argv) {
     if (msvs) {
       // Turn off the Microsoft logo on Windows
       argv.push('/nologo')
+      // No lingering msbuild processes and open file handles
+      argv.push('/nodeReuse:false')
     }
 
     // Specify the build type, Release by default

Original file line number	Diff line number	Diff line change
`@@ -141,6 +141,8 @@ async function build (gyp, argv) {`
`141`	`141`	`if (msvs) {`
`142`	`142`	`// Turn off the Microsoft logo on Windows`
`143`	`143`	`argv.push('/nologo')`
	`144`	`+ // No lingering msbuild processes and open file handles`
	`145`	`+ argv.push('/nodeReuse:false')`
`144`	`146`	`}`
`145`	`147`
`146`	`148`	`// Specify the build type, Release by default`