-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BR/EDR Support #242
Comments
Right now this library is LE only. If you have a proposal for a cross platform API that supports things like audio then I'd be happy to review it. |
Unfortunately I only have the resources to work with Linux, so if allowing BR/EDR connections would fundamentally break things, I probably won't be able to make an acceptable contribution in the near future. |
It's not about breaking things, but rather about making sure the API is designed well enough so that it works on different platforms (not just Linux). Especially since, as far as I know, BR/EDR Bluetooth is often more tightly integrated in the OS than BLE.
What do you mean? BR/EDR, if I understand correctly, only has some very limited uses such as A2DP, headset mode (for calls), and exchanging serial data. |
Sure, I can get into specifics. As far as implementation of BR/EDR scanning, I was thinking that the public API would need only change by adding scan filter parameters to the Scan function. I apologize if I ask any questions or make statements that seem odd as I'm a Bluetooth novice and have never really worked with BLE before. |
Yeah, this sort of thing really needs an implementation on at least two systems to ensure we have a cross platform API. I'd rather not implement something now and then have to break compatibility again once we add support for other OSes. You are of course free to fork the package and use it for your purposes. Some day we might add cross-platform support for BR/EDR and having a Linux implementation ready might be useful. |
I recently obtained a USB adapter for Windows. Maybe someday I'll open a PR for this 😀 |
Will this package function well with BR/EDR connections, or does it make assumptions that everything is LE?
This is a nice library, and I'd like to utilize it for cases such as pairing with audio devices that don't support LE (airpods, etc).
If it won't break the entire world, I could make a PR to add scan options to specify the transport, which is currently hardcoded to
"le"
.The text was updated successfully, but these errors were encountered: