Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mutate the options object #64

Open
panick-carousel opened this issue Jul 25, 2022 · 0 comments
Open

Do not mutate the options object #64

panick-carousel opened this issue Jul 25, 2022 · 0 comments

Comments

@panick-carousel
Copy link

The options object is passed in from the user and should not be mutated.

here is one example of this mutation occuring.

To fix it, I suggest doing options = {...options} as the first operation in the function call perhaps ?

An example of where this causes problems is if the objects object comes in frozen, then columnify throws an error.

Thank you for this library - it is very useful and I have used it for years before coming across this minor issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant