Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align decimals #43

Open
runvnc opened this issue Jun 27, 2016 · 2 comments
Open

Align decimals #43

runvnc opened this issue Jun 27, 2016 · 2 comments

Comments

@runvnc
Copy link

runvnc commented Jun 27, 2016

Wondering if anyone came up with a patch to align floating point columns by decimals, i.e. padding/alignment/truncation so that the decimal points in numbers line up ({align:'decimal'}).

Thanks.

@danyshaanan
Copy link
Collaborator

That's interesting.

I'd be happy to give it a shot. Any chance you can write the test? As in, duplicate and modify a test and its expected result to show how the API would look and what the expected result should be, and create a pull request.

That would be very helpful.

@runvnc
Copy link
Author

runvnc commented Jun 27, 2016

OK thanks I will take a look at writing the test this week.

On Mon, Jun 27, 2016 at 7:20 AM, Dany Shaanan [email protected]
wrote:

That's interesting.

I'd be happy to give it a shot. Any chance you can write the test? As in,
duplicate and modify a test
https://github.com/timoxley/columnify/blob/master/test/align-right.js
and its expected result
https://github.com/timoxley/columnify/blob/master/test/align-right-expected.txt
to show how the API would look and what the expected result should be, and
create a pull request.

That would be very helpful.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#43 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAVOnAYyMqHebPDIuzvbYFs6eTyxfI4Qks5qP9xDgaJpZM4I-sE2
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants