Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It will be more convenient if an extra param such as 'key' be added to dataTransform #36

Open
hustcer opened this issue Jan 11, 2016 · 4 comments

Comments

@hustcer
Copy link

hustcer commented Jan 11, 2016

Hi,
Thanks for the great work, and I think It will be more convenient if an extra param such as 'key' be added to dataTransform, sometimes we need to transform data according to which key current data is.

@timoxley
Copy link
Owner

@hustcer good idea, you can get it from reading the name property of the second argument to the dataTransform. This isn't documented though, so my bad. If you get this working, think you could send a docs PR?

@hustcer
Copy link
Author

hustcer commented Jan 29, 2016

I have tried and the second argument just displays nothing but {}, I got no key name? Is there anything wrong?

@kmgilbert100
Copy link

@hustcer @timoxley The same was happening with me... I added a PR that adds a 4th param called columnName not sure if this should be closed if theres some other fixed needed with the second argument?

@kmgilbert100
Copy link

@timoxley Looks like in the data you have to specify a name key to populate that column object? If you look at the example in my pr its how I am attempting to accomplish.. hoping can get that merged soon so I can pull it in from master to my project .. got it setup via npm link working exactly how I need it.. very useful feature :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants