Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datetime is not timezone aware #230

Open
tichkadzinga opened this issue Feb 15, 2018 · 0 comments · May be fixed by #231
Open

Datetime is not timezone aware #230

tichkadzinga opened this issue Feb 15, 2018 · 0 comments · May be fixed by #231

Comments

@tichkadzinga
Copy link

Parsing datetime discards 1) The milliseconds 2) Time Zone information. API documentation suggests only UTC is used. Comparison between timestamps referencing different time zones is error prone.

https://developer.ebay.com/Devzone/XML/docs/Reference/eBay/types/simpletypes.html#dateTime

I am proposing we add milliseconds and time zone information to the datetime object. This change will make timezone-naive applications fail with TypeError: can't compare offset-naive and offset-aware datetimes
tichkadzinga added a commit to tichkadzinga/ebaysdk-python that referenced this issue Feb 15, 2018
@tichkadzinga
time zone & millisecond in ISO 8601 parsing
4cf12be 
fixes timotheus#230
@tichkadzinga tichkadzinga linked a pull request Feb 15, 2018 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

time zone & millisecond in ISO 8601 parsing tichkadzinga/ebaysdk-python
1 participant
@tichkadzinga