Grant USAGE on debug schema #7265
Merged
+7
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erimatnor
added
the
debugging
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7265 +/- ##
===========================================
+ Coverage 80.06% 92.33% +12.26%
===========================================
Files 190 205 +15
Lines 37181 38433 +1252
Branches 9450 9962 +512
===========================================
+ Hits 29770 35487 +5717
+ Misses 2997 2946 -51
+ Partials 4414 0 -4414 ☔ View full report in Codecov by Sentry. |
mkindahl
approved these changes
Sep 11, 2024
|
Hmm why do we need another schema with the same setup like _timescaledb_functions. If public gets access to those why not add it to _timescaledb_functions? |
The schema is there, and we intend to add more debug functions to it. We can always reconsider the use of this schema later. So feel free to file an issue for that @svenklemm . |
fabriziomello
approved these changes
Sep 18, 2024
Make it possible for regular users to execute functions in the schema `_timescaledb_debug`. As a consequence, the `extension_state()` function in this schema can now be executed by "public". This is the only function in this schema and there is no security risk in making it accessible.
erimatnor
force-pushed
the
grant-usage-on-debug-schema
branch
from
c95c58d
to
fc5d07d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible for regular users to execute functions in the schema
_timescaledb_debug.As a consequence, the
extension_state()function in this schema can now be executed by "public". This is the only function in this schema and there is no security risk in making it accessible.Disable-check: force-changelog-file