Disable xids and empty transactions in TAP test #7264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erimatnor
approved these changes
Sep 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7264 +/- ##
===========================================
+ Coverage 80.06% 92.30% +12.23%
===========================================
Files 190 205 +15
Lines 37181 38433 +1252
Branches 9450 9962 +512
===========================================
+ Hits 29770 35476 +5706
+ Misses 2997 2957 -40
+ Partials 4414 0 -4414 ☔ View full report in Codecov by Sentry. |
mkindahl
force-pushed
the
fix-logrepl-test
branch
from
a949bcf
to
20f30de
Compare
akuzm
approved these changes
Sep 12, 2024
mkindahl
force-pushed
the
fix-logrepl-test
branch
from
20f30de
to
c0d70bb
Compare
mkindahl
force-pushed
the
fix-logrepl-test
branch
from
c0d70bb
to
160469e
Compare
mkindahl
force-pushed
the
fix-logrepl-test
branch
3 times, most recently
from
a93a155
to
fb77b3c
Compare
Instead of filtering the output of `pg_logical_slot_get_changes` we set the option `skip-empty-xacts` and clear `include-xids` to get stable tests. Since the option 'skip-empty-xacts' is set, this changes the order of messages since the BEGIN of a transaction is not generated until the decoder plugin can see that the transaction started and messages do not count as part of a transaction. We also remove transaction start and end marker (and strip trailing and leading whitespace) since these will appear in different places depending on the PostgreSQL version and they are not important for the correctness of the test.
mkindahl
force-pushed
the
fix-logrepl-test
branch
from
fb77b3c
to
be407c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of filtering the output of
pg_logical_slot_get_changeswe setthe option
skip-empty-xactsand clearinclude-xidsto get stabletests.
Since the option 'skip-empty-xacts' is set, this changes the order of
messages since the BEGIN of a transaction is not generated until the
decoder plugin can see that the transaction started and messages do not
count as part of a transaction.
We also remove transaction start and end marker (and strip trailing and
leading whitespace) since these will appear in different places
depending on the PostgreSQL version and they are not important for the
correctness of the test.
Disable-check: force-changelog-file