Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission for CoderSchool Prework #1

Open
tieubao opened this issue Feb 17, 2016 · 6 comments
Open

Submission for CoderSchool Prework #1

tieubao opened this issue Feb 17, 2016 · 6 comments

Comments

@tieubao
Copy link
Owner

tieubao commented Feb 17, 2016

Here my submission for the Tipper app. Thank you

/cc @coderschoolreview

@coderschoolreview
Copy link

Thank you for your Swift submission, tieubao!

🚫 Unfortunately there are some problems with your submission:

  • I couldn't find how much time you spent on the assignment. Please include the number of hours spent on your assignment in your README.md.
  • I couldn't find a walkthrough GIF referenced from your README.md. Please use RecordIt or LICEcap to record an animated GIF of your submission going through the required stories, and include it in your README.md.

@tieubao
Copy link
Owner Author

tieubao commented Feb 17, 2016

@coderschoolreview I'm updating the file, will ping you later tonight

@tieubao
Copy link
Owner Author

tieubao commented Feb 18, 2016

@coderschoolreview please help to check my latest version.

iOS is good 👍. Will try to release this app to AppStore also

@coderschoolreview
Copy link

Thank you for your Swift submission, tieubao!

😁 Everything looks good with the format of your submission. We'll be reviewing your submission soon!

@coderschoolreview
Copy link

👍 Excellent job with the Tip Calculator. This is one of the best submissions I've ever seen 🎉 😍 💯

Some small comments:

  • 😮 Good job with AutoLayout. We won't learn about AutoLayout until the second week of class, but it looks like you have a good understanding already. You have a few AutoLayout warnings and errors but we'll learn more about how to fix those in Week 2.
  • Great work with customizing the Keypad. It's very impressive 🌟 But for now, I cannot input the decimal number. The . button maybe not work well.
  • It's very creative to make the percentage and number of people editable. However, the behavior of these arrow buttons is a little confusing 😕
  • Nice work using Pod and put the Pods folder in .gitignore 👍
  • You should set the saving time for the bill amount as the the requirement asks.

Congratulation on completing the prework! The result will be emailed you next week.

@tieubao
Copy link
Owner Author

tieubao commented Feb 20, 2016

@coderschoolreview ah I found the bug with decimal number, something went wrong with it when I tried to handle the tip for group of people.

Will try to update the project in the next few days. Thank you for the feedback. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants