Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add Traefik v3 instructions #93

Merged
merged 2 commits into from
Dec 10, 2023
Merged

Conversation

rbauduin
Copy link
Contributor

The only difference is how swarm mode is activated, replacing

--providers.docker.swarmmode

by

--providers.swarm.endpoint=unix:///var/run/docker.sock

@ewurch
Copy link

ewurch commented Nov 5, 2023

Hi @rbauduin, I'm a fellow user of this stack for my VPS and I really liked your initiative to update Traefik. But I think you forgot to update the image tag on the traefik-v3 file:
https://github.com/tiangolo/dockerswarm.rocks/pull/93/files#diff-eed813aa598624c5d6849a2de675909068d9c0a5592a6db3bc6810fcd06a1001R7


traefik:
# Use the latest v2.2.x Traefik image available
image: traefik:v2.2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it supposed to be v3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, good catch, pushing an update

@tiangolo tiangolo changed the title Add Traefik v3 instructions ✨ Add Traefik v3 instructions Dec 10, 2023
@tiangolo
Copy link
Owner

Thank you! 🍰 ☕

@tiangolo tiangolo added the docs label Dec 10, 2023
@tiangolo tiangolo merged commit 8fa37b9 into tiangolo:master Dec 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants