-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address of only one recipient not shown but "+1" #7449
Comments
Investigating on this.. |
I was able to replicate the issue with the following steps:
Video evidence: 7449.mp4After analysing the issue, it looks like this behaviour is handler directly by
On multiple occasions Splitwise's TokenAutoComplete made changes to the modifiers on this class specifically, it might be worth opening a ticket on their board requesting that these issues are addressed. |
I can confirm this +1 behaviour. |
Note: Since we used the TokenAutoComplete library in a very specific way that didn't always match what it was intended for, we included a copy of the library in our repository and modified it to better suit our needs. The method responsible for "collapsing" the view is The logic on how many "tokens" to display is not quite right. It definitely doesn't reliably work for our recipient chips. I believe a fixed version of the code would need to use the width of Fixing this issue could be done in multiple stages. The easiest win is to never attempt to collapse the view when there's only one recipient chip and no additional text. With #8734 merged, the text in the chip will be correctly ellipsized when it is wider than the available space. |
Checklist
App version
6.603
Where did you get the app from?
Google Play
Android version
12
Device model
Sony Xperia 5 II
Steps to reproduce
long mail address in TO field
Expected behavior
mail address is shown
Actual behavior
+1 is shown
Logs
No response
The text was updated successfully, but these errors were encountered: