Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find a solution for importing CSS files (ShadowDOM bypass) for global styles #6

Open
1 of 5 tasks
thescientist13 opened this issue Nov 28, 2019 · 1 comment
Open
1 of 5 tasks
Assignees
Labels
question Further information is requested technical

Comments

@thescientist13
Copy link
Owner

Type of Change

  • New Feature Request
  • Documentation
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

In order to get global CSS styles working for diff2html I had to disable the ShadowDOM for now.

Mainly because I can't import them in with something like webpack since browser's will complain about CSS MIME types if trying to do something like.

import './app.css';

Details

Likely as part of #3 this could be solved if the files are now local, but I think bundling / import would still be an issue either way?

@thescientist13 thescientist13 added question Further information is requested technical labels Nov 28, 2019
@thescientist13 thescientist13 added this to the MVP milestone Nov 28, 2019
@thescientist13
Copy link
Owner Author

As part of the PR for #3 , es-module-shims was added, which should be able to support this. (i.e. CSS Modules)

@thescientist13 thescientist13 self-assigned this Nov 29, 2019
@thescientist13 thescientist13 removed this from the MVP milestone Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested technical
Projects
None yet
Development

No branches or pull requests

1 participant