Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/reloader: Provide option to use slog instead of go-kit #7677

Open
ArthurSens opened this issue Aug 30, 2024 · 0 comments
Open

pkg/reloader: Provide option to use slog instead of go-kit #7677

ArthurSens opened this issue Aug 30, 2024 · 0 comments

Comments

@ArthurSens
Copy link

Slog was added to the Go standard libraries as an alternative for structured logging. A lot of tools are trying to migrate to slog, aiming to remove their dependency tree in third-party libraries like go-kit

The reloader package still requires go-kit in its constructor:

"github.com/go-kit/log"

func New(logger log.Logger, reg prometheus.Registerer, o *Options) *Reloader {

Would it make sense to provide another one with slog?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant