Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

page: /tags/excerpt #211

Open
butterp1 opened this issue Jan 29, 2024 · 3 comments
Open

page: /tags/excerpt #211

butterp1 opened this issue Jan 29, 2024 · 3 comments

Comments

@butterp1
Copy link

butterp1 commented Jan 29, 2024

URLs

Explanation of immediate task

The trim regex given as an example to trim body for excerpt seems to trip up if textile is enable in the body field (prepending the truncated text with p>), no matter what the escape attributes. I have better luck with <txp:body escape="tags" trim="/^(<[^>]*>)*((?:\w+\W+){35})\w.*$/s" replace="$2&hellip;" />, which excludes initial tags.

Resources to support effort

Current to-dos

  • Maybe update example with note for textile users
@bloatware
Copy link
Member

Thank you for the report, but I'm not sure textile interferes here. Could you provide more details re the article body content?

@butterp1
Copy link
Author

butterp1 commented Jan 30, 2024

Hi,
I've just reinstated the trim regex from the TXP docs and made a test article using a couple of paragraphs of plain text. Screenshots attached of front and back end, firstly with Textile on then with it off.

I've only seen this happen on a couple of older sites, so may be something in the config or hosting conditions or a plugin.

I've tried the regex on the regex101 site and it removes the opening bracket from an opening p tag, so I'm guessing the regex trim happens before the transform / escape?

LEAVE TEXT UNTOUCHED
Screen Shot 2024-01-31 at 9 59 48 am

TEXTILE
Screen Shot 2024-01-31 at 9 58 33 am

@bloatware
Copy link
Member

Thank you. Have you also set escape="tags" attribute before trim? Unless php strip_tags() function is somehow disabled on your server (see diagnostics), it should have removed all html tags prior to trimming.

This said, the example regex might be a bit loose, indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants