New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace match-index with String.prototype.matchAll #55

Open

azu opened this issue Jul 17, 2023 · 1 comment

Labels

good first issue PR welcome Status: Proposal

Member

azu commented Jul 17, 2023 •

edited

Loading

match-indexはString.prototype.matchAll()とRegExp Match Indicesに置き換えられるはずです(String.prototype.matchAll()以前に作られたライブラリなので)

置き換えることで依存が減らせます

azu added Status: Proposal PR welcome labels

Member Author

azu commented Jul 17, 2023

String.prototype.matchAll()はNode.js 12+
RegExp Match IndicesはNode.js 14+なので、サポートが切れるはず

azu closed this as completed

azu reopened this

azu added the good first issue label

This was referenced Apr 26, 2024

fix(ja-nakaguro-or-halfwidth-space-between-katakana): replace match-index with String.prototype.matchAll #70

Merged

refactor(ja-space-after-exclamation): replace match-index with String.prototype.matchAll #72

Merged

refactor(ja-space-after-question): replace match-index with String.prototype.matchAll #73

Merged

refactor(ja-no-space-around-parentheses): replace match-index with String.prototype.matchAll #74

Merged

refactor(ja-no-space-between-full-width): replace match-index with String.prototype.matchAll #75

Merged

refactor(ja-space-between-half-and-full-width): replace match-index with String.prototype.matchAll #76

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment