Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Add forURL method to Wait action for Web #91

Open
japboy opened this issue Oct 18, 2024 · 1 comment · May be fixed by #93
Open

✨Add forURL method to Wait action for Web #91

japboy opened this issue Oct 18, 2024 · 1 comment · May be fixed by #93
Labels
enhancement New feature or request
Milestone

Comments

@japboy
Copy link

japboy commented Oct 18, 2024

What are you trying to do?

I just need page.waitForURL equivalent for @testla/screenplay-playwright and I think this can be included in Wait action.

Something like this:

import { Wait } from '@testla/screenplay-playwright/web';

await actor.attemptsTo(Wait.forURL('/path/to/wait');

I can write my own action instead though forURL method seems to suit for built-in Wait action, so it would be nice if it's implemented in built-in action.

Why is this important to you?

No response

How are you currently working around this?

No response

@japboy japboy added the enhancement New feature or request label Oct 18, 2024
@kbrueckner
Copy link
Contributor

Sounds reasonable. We'll have a look into this.
If you like and have a solution ready, you may want to open a merge request for this.

@kbrueckner kbrueckner linked a pull request Mar 19, 2025 that will close this issue
9 tasks
@kbrueckner kbrueckner linked a pull request Mar 19, 2025 that will close this issue
9 tasks
@kbrueckner kbrueckner added this to the 1.8.0 milestone Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants