Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ 2419566 ] Simplified proxy handling during AIO installation #444

Open
HolQue opened this issue Feb 13, 2025 · 1 comment
Open

[ 2419566 ] Simplified proxy handling during AIO installation #444

HolQue opened this issue Feb 13, 2025 · 1 comment
Labels

Comments

@HolQue
Copy link
Collaborator

HolQue commented Feb 13, 2025

The installation of the GitHub Copilot and also the execution of the GitHub Copilot require to define a proxy (if in general a proxy is required).

This is not a problem for AIO installers of the BIOS versions, because in this case the proxy is known and can be handled by the installer.

The AIO installers of the OSS versions do not know the proxy and do not know if a proxy is even necessary.

The current way this is handled by the installers, is a bit fuzzy. I propose to extend the AIO installation in the following way:

  • The GitHub Copilot should be added to the "Select Components" card of the installers. Because exactly this is the position, where the user shall select components. Why not also the GitHub Copilot?

    • If a user selects the GitHub Copilot, at end of installation the usual installation hints will be displayed (same as before).
    • If a user does not select the GitHub Copilot, the installation hints will be skipped by the installer. They are not required in this case. And this shortens the installation because a user will not be annoyed with details he do not need.
  • A card should be added to the AIO installer, asking the user if a proxy needs to be defined or not.

    • If a user does not select a proxy installation

      • If a user has not selected a GitHub Copilot installation

        Nothing more to do here.

      • If a user has selected a GitHub Copilot installation

        Because of a proxy is not required, the GitHub Copilot installation hint should be

        & "<installation path>\install-github-copilot-exts.ps1"

    • If a user selects a proxy installation

      The installer displays an input field where the user can insert the proxy address.

      The proxy is at least required in the VSCodium settings (file %ROBOTVSCODE%\data\user-data\User\settings.json). The installer should add this setting based on the users input before.

      • If a user has not selected a GitHub Copilot installation

        Nothing more to do here.

      • If a user has selected a GitHub Copilot installation

        Because of a proxy is required, the GitHub Copilot installation hint should be

        & "<installation path>\install-github-copilot-exts.ps1" --proxy <user input proxy address> --proxy-auth

@HolQue
Copy link
Collaborator Author

HolQue commented Feb 13, 2025

Addition:

Same flow in AIO installers of the BIOS versions. Except: These installers do not need to ask if a proxy needs to be defined. Because it already known, that a proxy is required.

@ngoan1608 ngoan1608 changed the title Simplified proxy handling during AIO installation [ 2419566 ] Simplified proxy handling during AIO installation Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants