Fix race condition in ErrProtocolNotSupported

Fixed a race condition that caused the library (and http proxy) to not
recognize ErrProtocolNotSupported, which indicates the vehicle does not
support the newer protocol.

The race condition was caused by code that attempted to handshake with
multiple vehicle subsystems (domains) in parallel. If one subsystem
returned ErrProtocolNotSupported, the pending requests to other
subsystems were canceled. In some cases, the context cancellation error
would be propagated to the down the stack instead of
ErrProtocolNotSupported.

With this fix, the library prioritizes non-context cancellation errors.

Author: sethterashima

internal/dispatcher/dispatcher.go

@@ -3,6 +3,7 @@ package dispatcher
 import (
 	"context"
 	"crypto/rand"
+	"errors"
 	"fmt"
 	"sync"
 	"time"
@@ -110,13 +111,16 @@ func (d *Dispatcher) StartSessions(ctx context.Context, domains []universal.Doma
 			results <- d.StartSession(aggregateContext, dom)
 		}(domain)
 	}
+	var err error
 	for i := 0; i < len(domains); i++ {
-		err := <-results
-		if err != nil {
+		err = <-results
+		// The aggregateContext is canceled if one of the handshakes fails. We don't want to return
+		// the Canceled error if ErrProtocolNotSupported is present.
+		if !errors.Is(err, context.Canceled) {
 			return err
 		}
 	}
-	return nil
+	return err
 }
 
 func (d *Dispatcher) createHandler(key *receiverKey) *receiver {

pkg/proxy/proxy.go

@@ -263,7 +263,7 @@ func (p *Proxy) handleVehicleCommand(acct *account.Account, w http.ResponseWrite
 	}
 	defer car.Disconnect()
 
-	if err := car.StartSession(ctx, nil); err == protocol.ErrProtocolNotSupported {
+	if err := car.StartSession(ctx, nil); errors.Is(err, protocol.ErrProtocolNotSupported) {
 		p.markUnsupportedVIN(vin)
 		p.forwardRequest(acct.Host, w, req)
 		return err