-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
D2JS - theme/center/pad has no effect on an svg #2307
Comments
Any ideas where to look in the codebase to fix this? Feels like a small colouring in thing should be a relatively quick fix people knew where to look? |
@MichaelCropper If you're inclined: Probably somewhere here: https://github.com/terrastruct/d2/blob/master/d2js/d2wasm/functions.go Which is the interface to go the Go functions from d2js: https://github.com/terrastruct/d2/tree/master/d2js/js |
@alixander Looks to be missing a few imports at the very top of the functions.go file, specifically;
I'm making this assumption based on what I can see in that file VS what I can see in the console log on the CONTRIBUTING.md guidelines with the packages listed there. I've not used Go before so bit of a learning curve to try and get a local dev environment spun up and attempt to take a stab at actually fixing this. Unlikely to be as simple as just adding in the missing imports, although I can see code references to Sketch and Theme in that same file, so perhaps it is just this which is missing? |
https://d2lang.com/tour/vars/#configuration-variables
Works on cli but doesn't work with wasm build/d2js.
The text was updated successfully, but these errors were encountered: