AWS EKS Managed Node Group creates a new launch template version on every run if enable_monitoring = false

[ib-ak]

Description

AWS EKS Node Group creates a new launch template version every time if enable_monitoring = false

terraform-aws-eks/modules/eks-managed-node-group/main.tf

Lines 243 to 249 in 50cb230

	dynamic "monitoring" {
	for_each = var.enable_monitoring ? [1] : []
	content {
	enabled = var.enable_monitoring
	}
	}

when enable_monitoring is false terraform will remove the enabled = false under monitoring

monitoring {
 - enabled = false -> null
 } 

If your request is for a new feature, please use the Feature request template.

• ✋ I have searched the open/closed issues and my issue is not listed.

⚠️ Note

Before you submit an issue, please perform the following first:

1. Remove the local .terraform directory (! ONLY if state is stored remotely, which hopefully you are following that best practice!): rm -rf .terraform/
2. Re-initialize the project root to pull down modules: terraform init
3. Re-attempt your terraform plan or apply and check if the issue still persists

Versions

• Module version [Required]: 19.21.0

• Terraform version: 1.3

• Provider version(s): 4.67

Reproduction Code [Required]

Run the example
https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/examples/eks-managed-node-group/eks-al2.tf

Steps to reproduce the behavior:

1. deploy this https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/examples/eks-managed-node-group/eks-al2.tf
2. redeploy it again without making any changes

Expected behavior

launch template should not change if there are no changes.

Actual behavior

a new version of launch template on every subsequent runs.

[github-actions]

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

[github-actions]

This issue was automatically closed because of stale in 10 days