Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support envd build from stdin #1461

Open
VoVAllen opened this issue Feb 3, 2023 · 1 comment
Open

feat: Support envd build from stdin #1461

VoVAllen opened this issue Feb 3, 2023 · 1 comment

Comments

@VoVAllen
Copy link
Member

VoVAllen commented Feb 3, 2023

Description

In flyte, they use syntax like

@task(
        config=EnvdConfig(
        os="ubuntu20.04",
        pip_packages=["tensorflow"],
        language="python",
)

to configure the envd dependency. Then it needs to call envd build. it's better for envd build to support stdin input, which makes it easier for flyte to call envd


Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

@cutecutecat
Copy link
Member

What about syntax like:

@task(
        config=EnvdConfig(
                script="path/to/*.envd/dir",
                tag="train:latest",
                func="filename:func"
        )
)

If users straightly give parameters to the stdin of build, without a entry script, they might be inaccessible to most envd features, like expose, or we would design a huge EnvdConfig.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants