Skip to content
This repository has been archived by the owner on Jun 3, 2020. It is now read-only.

Structured logging #237

Open
tarcieri opened this issue Apr 20, 2019 · 1 comment
Open

Structured logging #237

tarcieri opened this issue Apr 20, 2019 · 1 comment

Comments

@tarcieri
Copy link
Contributor

tarcieri commented Apr 20, 2019

The KMS logging story is really bad right now (see #236). As an MVP it uses the most minimal logging solution available in Rust right now, but there are a number of others worth considering.

Problems

Crossed-out items are handled upstream in Abscissa now.

Structured Logging

Alternatives

  • tokio-trace tracing is an advanced asynchronous logging framework for Rust which is compatible with the log crate. It definitely seems like the way to go if the KMS were to switch to tokio (which should hopefully be possible soon), but can be used without tokio via the existing log-crate compatibility.
@tarcieri
Copy link
Contributor Author

Pretty much the whole stack right now uses the log crate. This makes tokio-trace seem particularly appealing for retrofitting more advanced logging immediately, as until rust-lang/log#149 is sorted out it provides both backwards compatibility with log and a much more advanced/comprehensive logging solution.

Alternatively, slog seems like the best option for a native structured logging solution. We don't presently use tokio, so we wouldn't immediately benefit from the asynchronous tracing/logging support in tokio-trace.

@tarcieri tarcieri changed the title Logging improvements Structured logging Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant